Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempus 947 publish data quality notification to events #1015

Merged

Conversation

Himanshu-it
Copy link
Contributor

@Himanshu-it Himanshu-it commented Jan 16, 2019

Thank you for submitting a contribution to Tempus.

In order to streamline the review of the contribution please
ensure the following steps have been taken:

For all changes:

  • Is there a Waffle ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with Tempus-XXXX where XXXX is the waffle number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically dev)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root Tempus folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you added documentation for any UI or API related changes to the /docs folder

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@@ -17,6 +17,7 @@
package com.hashmapinc.server.transport.mqtt.adaptors;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not needed remove these redundant imports

@XxChauhanxX XxChauhanxX added the PR label Jan 16, 2019
@Himanshu-it Himanshu-it force-pushed the Tempus-947-Publish-data-quality-notification-to-events branch from 951cd8d to 13fbc5a Compare January 16, 2019 10:27
@Himanshu-it Himanshu-it force-pushed the Tempus-947-Publish-data-quality-notification-to-events branch from 13fbc5a to 23cf357 Compare January 16, 2019 11:15
@Himanshu-it Himanshu-it merged commit 4a34180 into dev Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants