Add first working prototype #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
force-pushed
the
first-working-prototype
branch
from
3e10510
to
b8c3b40
Compare
mbovel
force-pushed
the
first-working-prototype
branch
from
b8c3b40
to
f69b4d9
Compare
MaximeKjaer
approved these changes
Aug 27, 2019
| describe: "Output file", | ||
| type: "string" | ||
| }), | ||
| argv => { |
There was a problem hiding this comment.
You can destructure argv here directly for extra street cred
| const om = toOM(parse(inputString)); | ||
| const outputString = renderToStaticMarkup(React.createElement(Document, om)); | ||
| if (output) fs.writeFileSync(output, outputString); | ||
| // tslint:disable-next-line:no-console |
There was a problem hiding this comment.
Perhaps the no-console rule of TSLint isn't very appropriate for a CLI
| export function Ref({ idRef }: RefOM) { | ||
| const section = idRef.target; | ||
| if (section) return <a href={"#" + section.id}>{section.title}</a>; | ||
| else return <strong>???</strong>; |
There was a problem hiding this comment.
You could add a title attribute for better UX
| return ( | ||
| <section id={id}> | ||
| <h1> | ||
| {counter.join(".")} {toReact(title)} |
There was a problem hiding this comment.
Omg how horrible to not put a dot at the end
| import { SectionOM } from "./SectionOM"; | ||
| import { StrongOM } from "./StrongOM"; | ||
|
|
||
| export type OM = DocumentOM | SectionOM | ParagraphOM | EmphasisOM | StrongOM | RefOM; |
There was a problem hiding this comment.
This could perhaps all be in one file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.