Skip to content

Commit

Permalink
⬇️ Downgrade to elixir 1.6.0 to match CI elixir version
Browse files Browse the repository at this point in the history
  • Loading branch information
vnegrisolo committed Feb 1, 2019
1 parent 102db24 commit 8a20327
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 15 deletions.
3 changes: 2 additions & 1 deletion .tool-versions
@@ -1 +1,2 @@
elixir 1.7.0
elixir 1.6.0
erlang 20.3.8.9
21 changes: 9 additions & 12 deletions lib/mix/tasks/tilex/hdb.ex
Expand Up @@ -56,18 +56,15 @@ defmodule Mix.Tasks.Tilex.Hdb do

defp fetch_heroku_dsn(heroku_app) do
result =
System.cmd(
"heroku",
[
"run",
"-a",
heroku_app,
"--no-notify",
"--no-tty",
"-x",
"sh -c 'echo $DATABASE_URL'"
]
)
System.cmd("heroku", [
"run",
"-a",
heroku_app,
"--no-notify",
"--no-tty",
"-x",
"sh -c 'echo $DATABASE_URL'"
])

case result do
{dsn, 0} -> {:ok, String.trim(dsn)}
Expand Down
3 changes: 1 addition & 2 deletions test/features/visitor_views_post_test.exs
Expand Up @@ -45,8 +45,7 @@ defmodule VisitorViewsPostTest do
assert Regex.match?(~r"#{post.slug}", path)
end

test "the page shows a post with the correct timezone if given",
%{session: session} do
test "the page shows a post with the correct timezone if given", %{session: session} do
Application.put_env(:tilex, :date_display_tz, "America/Chicago")

developer = Factory.insert!(:developer)
Expand Down

3 comments on commit 8a20327

@dkarter
Copy link
Contributor

@dkarter dkarter commented on 8a20327 Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vnegrisolo why downgrade? why not upgrade CI?

@dkarter
Copy link
Contributor

@dkarter dkarter commented on 8a20327 Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind fixed in this PR: #337 :)

@vnegrisolo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkarter I downgraded the elixir version of my PR code only for our development environment just to match the version on the heroku servers. I prefer to keep PRs with less changes. So on a following PR I was planing to upgrade the elixir for all tool-versions, elixir_buildpack and CI.. anyway, thanks for upgrading that 💯

Please sign in to comment.