Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept plain old http[s] scheme #12

Open
mcandre opened this issue Apr 9, 2019 · 1 comment · May be fixed by #16
Open

Accept plain old http[s] scheme #12

mcandre opened this issue Apr 9, 2019 · 1 comment · May be fixed by #16

Comments

@mcandre
Copy link

mcandre commented Apr 9, 2019

Please let users input WebSocket URL's as http / https, since that's how WebSocket addresses are actually served and used.
@watsoncj
Copy link

watsoncj commented May 7, 2019

Agreed. The upgrade from http to ws would be useful in many cases.

Connecting to an http server with ws:// schema results in websocket: bad handshake

Attempting to use http:// schema results in: malformed ws or wss URL

brian-brazil added a commit to brian-brazil/ws that referenced this issue Dec 22, 2019
@brian-brazil
Allow for incorrect and missing schemes.
fb05730 
Fixes hashrocket#12

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil added a commit to brian-brazil/ws that referenced this issue Dec 22, 2019
@brian-brazil
Allow for incorrect and missing schemes.
660f45f 
Fixes hashrocket#12

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil added a commit to brian-brazil/ws that referenced this issue Dec 22, 2019
@brian-brazil
Allow for incorrect and missing schemes.
51992ac 
Fixes hashrocket#12

Also picked up a few unrelated gofmt changes.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil added a commit to brian-brazil/ws that referenced this issue Dec 22, 2019
@brian-brazil
Allow for incorrect and missing schemes.
aeeb59c 
Fixes hashrocket#12

Also picked up a few unrelated gofmt changes.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
@brian-brazil brian-brazil linked a pull request Dec 22, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for incorrect and missing schemes. brian-brazil/ws
2 participants
@mcandre @watsoncj