Merge pull request #971 from hashtopolis/issue/969

Fix create supertask fails when crackerType != pretask.crackerType
hashtopolis · Aug 29, 2023 · 29e1c44 · 29e1c44
2 parents 0e4b833 + 9f5542b
commit 29e1c44
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/doc/changelog.md b/doc/changelog.md
@@ -3,6 +3,7 @@
 ## Bugfixes
 - Clicking pretask in Supertask create screen now directs correctly to the pretask and not a task with the same id (#945)
 - Pretask attackCmd parameter was not checked for maximum length of 256 on creation (#963)
+- Creating supertask fails when provided crackerType != pretask.crackerType (#969)
 
 ## New feature
 - Number of agents per supertask/taskwrapper can be limited (#769).

diff --git a/src/inc/utils/SupertaskUtils.class.php b/src/inc/utils/SupertaskUtils.class.php
@@ -279,7 +279,7 @@ public static function runSupertask($supertaskId, $hashlistId, $crackerId) {
     foreach ($pretasks as $pretask) {
       $crackerBinaryId = $cracker->getId();
       if ($cracker->getCrackerBinaryTypeId() != $pretask->getCrackerBinaryTypeId()) {
-        $crackerBinaryId = CrackerBinaryUtils::getNewestVersion($pretask->getCrackerBinaryTypeId());
+        $crackerBinaryId = CrackerBinaryUtils::getNewestVersion($pretask->getCrackerBinaryTypeId())->getId();
       }
 
       $task = new Task(