Merge pull request #964 from rixvet/issue/963

Fix incorrect parameter checked
hashtopolis · Aug 28, 2023 · c970231 · c970231
2 parents 8678fc5 + 43d1a12
commit c970231
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/doc/changelog.md b/doc/changelog.md
@@ -2,6 +2,7 @@
 
 ## Bugfixes
 - Clicking pretask in Supertask create screen now directs correctly to the pretask and not a task with the same id (#945)
+- Pretask attackCmd parameter was not checked for maximum length of 256 on creation (#963)
 
 
 # v0.13.1 -> v0.14.0

diff --git a/src/inc/utils/PretaskUtils.class.php b/src/inc/utils/PretaskUtils.class.php
@@ -305,7 +305,7 @@ public static function createPretask($name, $cmdLine, $chunkTime, $statusTimer,
     else if (strpos($cmdLine, SConfig::getInstance()->getVal(DConfig::HASHLIST_ALIAS)) === false) {
       throw new HTException("The attack command does not contain the hashlist alias!");
     }
-    else if (strlen($attackCmd) > 256) {
+    else if (strlen($cmdLine) > 256) {
       throw new HTException("Attack command is too long (max 256 characters)!");
     }
     else if (Util::containsBlacklistedChars($cmdLine)) {