Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Settings priority in #/tasks/show-tasks for normal task does not apply to taskwrapper #989

Closed
zyronix opened this issue Sep 5, 2023 · 3 comments · Fixed by #990
Closed
Assignees
Labels
bug Something isn't working server Hashtopolis API/Server related

Comments

@zyronix
Copy link
Member

zyronix commented Sep 5, 2023

Version Information

master

Hashcat

No response

Description

When I set the priority of a normal task (not a runningSuperTask). The priority is not applied on the TaskWrapper database object, and thus the priority is not implemented.

When patching priority and maxagent on a Task object, also reverse patch the taskwrapper object if it is not a supertask.

@zyronix zyronix added bug Something isn't working server Hashtopolis API/Server related labels Sep 5, 2023
@rixvet
Copy link
Collaborator

rixvet commented Sep 5, 2023

This almost feels something which is a necessary evil to implement. It breaks the basic concepts of the APIv2/ui section modelling since this will causes changes at one model be effected to other models 'magically', which should be an helper function, how-ever since going forward we want to hide the 'TaskWrapper' object (again see #906) so let's go for it 😇

@zyronix
Copy link
Member Author

zyronix commented Sep 5, 2023

Another solution could be to make the task view about viewing taskwrappers. Once clicked you'll view the tasks inside the taskwrapper; even when only one task is available. The only behavior is that when tasktype is task and not supertask, the priority and maxagents cannot be patched through the api. As they can only bet set on the taskwrapper. What you think about this idea?

rixvet added a commit that referenced this issue Sep 5, 2023
The task object priority is servering asl  'dummy' for  normal tasks.

Related taskwrapper object should be updated as well,
since the 'real' priority scheduling is done using the
Taskwrapper object.

Fixes: #989
@rixvet
Copy link
Collaborator

rixvet commented Sep 6, 2023

Another solution could be to make the task view about viewing taskwrappers. Once clicked you'll view the tasks inside the taskwrapper; even when only one task is available. The only behavior is that when tasktype is task and not supertask, the priority and maxagents cannot be patched through the api. As they can only bet set on the taskwrapper. What you think about this idea?

I think it is rather confusing, both from a design point-of-view as from user point-of-view, since this means we updating/creation behavior based on conditionals within the object. Maybe hiding the taskWrapper completely and deal with an new endpoint for 'group of tasks' makes it easier to understand. Let's think of it in the context of #991.

@zyronix zyronix closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server Hashtopolis API/Server related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants