Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: prevent updating email_verified_at field by the user role #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security: prevent updating email_verified_at field by the user role #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Http/Controllers/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,14 @@ public function update(Request $request, User $user) {
$user->name = $request->name ?? $user->name;
$user->email = $request->email ?? $user->email;
$user->password = $request->password ? Hash::make($request->password) : $user->password;
$user->email_verified_at = $request->email_verified_at ?? $user->email_verified_at;

//check if the logged in user is updating it's own record

$loggedInUser = $request->user();
if ($loggedInUser->id == $user->id) {
$user->update();
} elseif ($loggedInUser->tokenCan('admin') || $loggedInUser->tokenCan('super-admin')) {
$user->email_verified_at = $request->email_verified_at ?? $user->email_verified_at;
$user->update();
} else {
throw new MissingAbilityException('Not Authorized');
Expand Down