Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore verboseBatch functionality #59

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Restore verboseBatch functionality #59

merged 2 commits into from
Jun 6, 2021

Conversation

rolsdorph
Copy link
Contributor

Looks like verboseBatch has just been another name for quickBatch for quite some time!

QuickCheck has a verboseCheckWith that's essentially the same as the quickCheckWith we're already using:

verboseCheckWith :: Testable prop => Args -> prop -> IO ()
verboseCheckWith args p = quickCheckWith args (verbose p)

I believe it's what we're looking for in order to make verboseBatch verbose again.

@rolsdorph
Restore verboseBatch functionality
9271b76 
Looks like verboseBatch has just been another name for quickBatch for
quite some time!

I believe QuickChecks verboseCheckWith should be what we're looking for
in order to make it work again.
sjakobi
sjakobi reviewed Jun 6, 2021
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with QC internals, but this looks very reasonable. Thanks!

src/Test/QuickCheck/Checkers.hs Show resolved Hide resolved
@rolsdorph @sjakobi
Update src/Test/QuickCheck/Checkers.hs
e3acb37 
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@sjakobi sjakobi requested a review from conal June 6, 2021 20:43
conal
conal approved these changes Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@conal conal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conal conal merged commit 59de8ad into haskell-checkers:master Jun 6, 2021
@rolsdorph rolsdorph deleted the verbosebatch branch June 7, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conal conal conal approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rolsdorph @conal @sjakobi