-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements bifoldable test #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Do you have a source for these laws?
They come from the Data.Bifoldable haddocks. There is one more law I forget to include:
This is only relevant if you have a Bifunctor. Would we put it in a separate test? |
Yes, we can add this in the style of the existing Regarding compatibility with GHC 7.10 and 8.0, I'll try to drop support for these soon, so we can merge your PRs without breaking CI. |
Could you rebase? |
aa65254
to
98f3c1f
Compare
98f3c1f
to
f1df51b
Compare
done! |
Resolves issue #48. We could reduce the number of type parameters by merging
c
andm
, but I didn't want it to appear thatbifoldr f g z t ≡ appEndo (bifoldMap (Endo . f) (Endo . g) t) z
requires a monoid onc