Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackage release #50

Closed
andreabedini opened this issue Apr 20, 2021 · 6 comments · Fixed by #70
Closed

Hackage release #50

andreabedini opened this issue Apr 20, 2021 · 6 comments · Fixed by #70

Comments

@andreabedini
Copy link

Hi all,

thanks for your work! Is there any chance to have the package relased on Hackage? Any blockers?

Thanks,
Andrea

@dpwiz
Copy link
Member

dpwiz commented Apr 20, 2021

The internals are still in flux and there's some CI legwork to be done for uploading docs.

Meanwhile, both cabal and stack projects may use it with git urls.
And... I doubt it would appear on stackage snapshots, so one would have to set their dependencies explicitly anyway.

What are the benefits you see from having the package uploaded? Visibility, haddocs,... anything else?

@ocharles
Copy link
Member

For me the most important signal from a release is "we're confident in what we've done". We're close to that point, but I don't think quite there yet

@andreabedini
Copy link
Author

Thank you @dpwiz and @ocharles.

Is there an issue to track the required CI legwork? I will see if I can help.

Unfortunately cabal doesn't pull submodules so pointing source-repository-package to GitHub doesn't work for the moment. See haskell/cabal#5536.

I'll work from a local checkout to the time being.

@dpwiz
Copy link
Member

dpwiz commented Apr 21, 2021

This is sad indeed.

@ocharles Let's set up a package with a version like 0.0.210421.0 and all the warning signs. This should hurt nobody and benefit some.

@dpwiz dpwiz changed the title Hackage release? Hackage release Apr 21, 2021
@dpwiz dpwiz closed this as completed in #70 Jun 30, 2021
@dpwiz
Copy link
Member

dpwiz commented Jun 30, 2021

Uh-oh. C++ code is missing in sdist.

@dpwiz dpwiz reopened this Jun 30, 2021
@dpwiz dpwiz closed this as completed in bfe8453 Jun 30, 2021
@andreabedini
Copy link
Author

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants