Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Wayland support #270

Closed
ribosomerocker opened this issue Jul 2, 2022 · 13 comments
Closed

No Wayland support #270

ribosomerocker opened this issue Jul 2, 2022 · 13 comments

Comments

@ribosomerocker
Copy link

Hello! I have been trying to get a program I've written to work in Wayland by setting the environment variable
export SDL_VIDEODRIVER=wayland
but I get this error:
SDLCallFailed {sdlExceptionCaller = "SDL.Init.init", sdlFunction = "SDL_Init", sdlExceptionError = "wayland not available"}

From what I know, SDL2 already supports Wayland at this point; so I am rather confused how it doesn't work with sdl2.

@ocharles
Copy link
Member

ocharles commented Jul 2, 2022

I think it would help to see a C sample that works for you on Wayland. Next, we can see if we can get it working in Haskell.

@ribosomerocker
Copy link
Author

https://bpa.st/USTA
This is a very {bad,small} example. It creates a white window. If I run it with SDL_VIDEODRIVER=wayland, then it uses Wayland instead of XWayland. But if I try any Haskell sdl2 project with that environment variable, I get the aforementioned error.

@ribosomerocker
Copy link
Author

Oh, sorry. Misclicked!

@ribosomerocker ribosomerocker reopened this Jul 3, 2022
@ribosomerocker
Copy link
Author

ribosomerocker commented Jul 5, 2022

I think I figured out the issue. When this didn't work, I was using surfaces. But in the meantime I've switched to textures; and they seem to work for Wayland. I'll do some testing.

@ocharles
Copy link
Member

ocharles commented Jul 6, 2022

I'm afraid I don't think anyone is actively looking at this at the moment.

@ocharles
Copy link
Member

ocharles commented Jul 6, 2022

What would help would be to have a reproducible example in Haskell that mimics the C you provided

@ribosomerocker
Copy link
Author

ribosomerocker commented Jul 8, 2022

This doesn't quite mimic the C, but it does most of it: https://bpa.st/ZCXQ
So, here's the conclusion I've arrived at: In haskell sdl2, surfaces are not Wayland compatible. But textures are.

Maybe you should encourage the usage of textures instead of surfaces?

@dpwiz
Copy link
Member

dpwiz commented Jul 19, 2022

The bpa.st links are all 404d out )=

@coder3112
Copy link

@MonAaraj can you please either

  1. Revive the links you gave
  2. Post the minimal, reproducible example in the comments themselves so that they are (more) permanent.
    Thanks!

@ribosomerocker
Copy link
Author

I can't exactly revive them, but I can give you a """minimal""" reproducible example.

Main.hs
#!/usr/bin/env cabal
{-# LANGUAGE OverloadedStrings #-}

{- cabal:
build-depends: base, sdl2, text, linear
-}

import SDL
import Linear (V4(..))
import Control.Monad (unless)

main :: IO ()
main = do
  initializeAll
  window <- createWindow "My SDL Application" defaultWindow
  renderer <- createRenderer window (-1) defaultRenderer
  screen <- getWindowSurface window
  appLoop renderer
  destroyWindow window

appLoop :: Renderer -> IO ()
appLoop renderer = do
  events <- pollEvents
  let eventIsQPress event =
        case eventPayload event of
          KeyboardEvent keyboardEvent ->
            keyboardEventKeyMotion keyboardEvent == Pressed &&
            keysymKeycode (keyboardEventKeysym keyboardEvent) == KeycodeQ
          _ -> False
      qPressed = any eventIsQPress events
  rendererDrawColor renderer $= V4 0 0 255 255
  clear renderer
  present renderer
  unless qPressed (appLoop renderer)

As mentioned earlier, if you run this with SDL_VIDEODRIVER=wayland, then it says:
script: SDLCallFailed {sdlExceptionCaller = "SDL.Video.getWindowSurface", sdlFunction = "SDL_GetWindowSurface", sdlExceptionError = "No hardware accelerated renderers available"}

But, if I don't use surfaces at all, instead only textures, then it works fine for Wayland.

@hanst99
Copy link
Contributor

hanst99 commented Aug 21, 2022

@MonAaraj Using a screen surface together with the SDL_Renderer API like you're doing here is not supported by SDL itself: see documention. This API is mostly outmoded anyway, it's more useful as a temporary utility for porting SDL1.x code. Using a screen surface by its nature keeps you from using hardware accelerated rendering, which is not what you want because software rendering is somewhere on the order to thousands to millions of times slower than accelerated, depending on what exactly you're doing.

@ribosomerocker
Copy link
Author

Alright, thank you very much. I will be closing this issue.

@dpwiz
Copy link
Member

dpwiz commented Aug 23, 2022

I wonder what would be a correct place to put the wayland/texture notice. Should the entire Surface block get a heads-up / deprecation notice? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants