Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exception to the LGPL for the generated libraries to allow static linking #195

Merged
merged 1 commit into from Nov 3, 2018

Conversation

CLowcay
Copy link
Contributor

@CLowcay CLowcay commented Oct 13, 2018

Normally, under the terms of the LGPL, when an application is linked against an LGPL library, the end user must be able to modify and replace the LGPL part of the application. This is difficult for statically linked Haskell libraries in GHC, so application authors that use LGPL code may be obliged to supply source code for their applications.

This pull request adds an exception to the licenses of the generated bindings to explicitly allow static linking. This exception is based on https://github.com/gtkd-developers/GtkD/blob/master/COPYING.

If this exception is acceptable to the project maintainers, then I would also like to extend it to the haskell-gi-base and haskell-gi libraries since all of the generated bindings are dependent on those libraries.

Copy link
Collaborator

@garetxe garetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pull request!

The changes to the license themselves look good, just a couple of minor comments about the code itself.

bindings/genBuildInfo.hs Outdated Show resolved Hide resolved
lib/Data/GI/CodeGen/ProjectInfo.hs Show resolved Hide resolved
Add an exception to the LGPL for the generated libraries to allow static
linking.

Normally, under the terms of the LGPL, when an application is linked against an
LGPL library, the end user must be able to modify and replace the LGPL part of
the application. This is difficult for statically linked Haskell libraries in
GHC, so application authors that use LGPL code may be obliged to supply source
code for their applications.
@garetxe garetxe merged commit 41335d2 into haskell-gi:master Nov 3, 2018
@garetxe
Copy link
Collaborator

garetxe commented Nov 3, 2018

Thanks a lot, merged!

I will try to find some time to re-release all bindings with the new license soon, but in the meanwhile, if there is any binding you are particularly interested in, please let me know.

@CLowcay
Copy link
Contributor Author

CLowcay commented Nov 5, 2018

Thanks for merging those license changes. Much appreciated. I will raise a second pull request very soon to apply the same license change to haskell-gi-base and haskell-gi since they are both dependencies of all the bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants