Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media types for GitHub API previews #367

Conversation

robbiemcmichael
Copy link
Contributor

Adds support for the media types used by API previews. This will allow users of this library to use the existing GenRequest type and its constructors when writing functions that use endpoints from API previews.

@phadej
Copy link
Contributor

phadej commented May 23, 2019

I don't feel I'd like to keep that preview list explicitly in the library.

@robbiemcmichael
Copy link
Contributor Author

I had a go first at refactoring things to allow the media types externally, but it started to get seriously messy. I was hoping you might accept having the list of media types in this library because those strings should at least be stable, but maybe I'll have to give the refactoring another shot instead.

@phadej
Copy link
Contributor

phadej commented May 23, 2019

I think we can change MediaType into MediaType ext or make it somehow extensible.
I'll try to make new github release soon, and this is something which would be nice to have; so even more stuff can be done outside the library.

I'll see what I can do, Draft Pull Requests seems to be something which is easy to test with.

@phadej phadej self-assigned this May 23, 2019
@phadej
Copy link
Contributor

phadej commented May 30, 2019

Superseded by #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants