Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull requests reviews API uses issue number #409

Merged
merged 1 commit into from Oct 22, 2019
Merged

Pull requests reviews API uses issue number #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/GitHub/PullRequestReviewsSpec.hs
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
module GitHub.PullRequestReviewsSpec where

import qualified GitHub
import GitHub.Data.Id (Id (Id))
import GitHub.Data (IssueNumber (IssueNumber))

import Prelude ()
import Prelude.Compat
Expand All @@ -29,4 +29,4 @@ spec = do
cs `shouldSatisfy` isRight
where
prs =
[("phadej", "github", Id 268)]
[("phadej", "github", IssueNumber 268)]
18 changes: 9 additions & 9 deletions src/GitHub/Endpoints/PullRequests/Reviews.hs
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ import Prelude ()
pullRequestReviewsR
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> FetchCount
-> Request k (Vector Review)
pullRequestReviewsR owner repo prid =
Expand All @@ -50,7 +50,7 @@ pullRequestReviewsR owner repo prid =
pullRequestReviews
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> IO (Either Error (Vector Review))
pullRequestReviews owner repo prid =
executeRequest' $ pullRequestReviewsR owner repo prid FetchAll
Expand All @@ -63,7 +63,7 @@ pullRequestReviews'
:: Maybe Auth
-> Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> IO (Either Error (Vector Review))
pullRequestReviews' auth owner repo pr =
executeRequestMaybe auth $ pullRequestReviewsR owner repo pr FetchAll
Expand All @@ -73,7 +73,7 @@ pullRequestReviews' auth owner repo pr =
pullRequestReviewR
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> Request k Review
pullRequestReviewR owner repo prid rid =
Expand All @@ -95,7 +95,7 @@ pullRequestReviewR owner repo prid rid =
pullRequestReview
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> IO (Either Error Review)
pullRequestReview owner repo prid rid =
Expand All @@ -110,7 +110,7 @@ pullRequestReview'
:: Maybe Auth
-> Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> IO (Either Error Review)
pullRequestReview' auth owner repo prid rid =
Expand All @@ -121,7 +121,7 @@ pullRequestReview' auth owner repo prid rid =
pullRequestReviewCommentsR
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> Request k [ReviewComment]
pullRequestReviewCommentsR owner repo prid rid =
Expand All @@ -144,7 +144,7 @@ pullRequestReviewCommentsR owner repo prid rid =
pullRequestReviewCommentsIO
:: Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> IO (Either Error [ReviewComment])
pullRequestReviewCommentsIO owner repo prid rid =
Expand All @@ -158,7 +158,7 @@ pullRequestReviewCommentsIO'
:: Maybe Auth
-> Name Owner
-> Name Repo
-> Id PullRequest
-> IssueNumber
-> Id Review
-> IO (Either Error [ReviewComment])
pullRequestReviewCommentsIO' auth owner repo prid rid =
Expand Down