Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix and bare sockets #44

Conversation

akshaymankar
Copy link

Fixes #42

I am not entirely certain about using localhost as the Authority. I added support for bare sockets because it seemed easy enough.

Copy link
Member

@lucasdicioccio lucasdicioccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code aspects of the patch looks good to me.

Can you:

  • grep to see if some examples / the bench tool (i believe nothing does) needs updating
  • add an entry to the changelog (credit yourself for the patch <3 )

@akshaymankar
Copy link
Author

  • grep to see if some examples / the bench tool (i believe nothing does) needs updating

I couldn't find anything. I compiled all the packages, nothing failed.

  • add an entry to the changelog (credit yourself for the patch <3 )

I added a link to this PR.

@lucasdicioccio
Copy link
Member

Thank you Akshay!

The build before the doc+changelog commits worked, it looks like it timed out this one time. Restarting it would likely mostly waste resources at Travis => merging that.

@lucasdicioccio lucasdicioccio merged commit fcc9e6f into haskell-grpc-native:master Nov 22, 2020
@akshaymankar akshaymankar deleted the support-unix-and-bare-sockets branch November 22, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unix sockets in http2-client-grpc
2 participants