Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress configure warning on option --with-compiler passed by Cabal #21

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Suppress configure warning on option --with-compiler passed by Cabal #21

merged 8 commits into from
Mar 29, 2023

Conversation

lyokha
Copy link
Collaborator

@lyokha lyokha commented Mar 28, 2023

Fixes #20.

lyokha and others added 8 commits March 28, 2023 12:59
@lyokha @andreasabel
res_ninit() requires cleanup with res_nclose()
4720d5c 
Linux man 3 resolver says:
    Every call to res_ninit() requires a corresponding call to
    res_nclose() to free memory allocated by res_ninit() and subsequent
    calls to res_nquery().
@lyokha @andreasabel
Collect resolv init and finalization actions in a separate function
9413eba 
withCResInit which makes sure that allocated resources get correctly
released by wrapping actions following a successful call to c_res_init
in finally handler.
@lyokha @andreasabel
Wrap the entire body of withCResInit in finally (c_res_close stptr)
029d85a 
This protects against asynchronous exceptions. If an asynchronous
exception happens somewhere inside of

    rc1 <- c_res_opt_set_use_dnssec stptr
    unless (rc1 == 0) $
        fail "res_init(3) failed"
    resetErrno

then it may leak memory after successful call to res_ninit() inside
c_res_opt_set_use_dnssec.

Note that it is safe to run c_res_close stptr if all fields of stptr
are memzeroed (which is our case before the call to res_ninit()): this
means that wrapping the entire body of withCResInit is safe even if an
asynchronous exception occurs before the call to res_ninit().
@lyokha @andreasabel
Do proper initialization and finalization with bracket in withCResInit
5804230
@andreasabel
Cosmetics: minimize changes: keep redundant do, original indentation
817092f
@andreasabel
Move resetErrno to the initializer part of withCResInit
b797b31
@lyokha
Merge remote-tracking branch 'upstream/master'
1df6ad2
@lyokha
Suppress configure warning on option --with-compiler passed by Cabal
63205d2 
Fixes haskell-hvr#20.
@lyokha
Copy link
Collaborator Author

lyokha commented Mar 28, 2023

Not sure why it lists older commits. Probably it must be re-submitted.

@andreasabel andreasabel merged commit adda269 into haskell-hvr:master Mar 29, 2023
@andreasabel
Copy link
Member

Merging by squashing went fine.

I still got this warning:

$ cabal build
Configuring resolv-0.1.2.0...
configure: WARNING: unrecognized options: --with-compiler

But after running autoreconf it vanished. So, yes working as intended!

@andreasabel
Copy link
Member

andreasabel commented Mar 29, 2023 •
edited
Loading

@lyokha

Not sure why it lists older commits.

Maybe you need to pull master. If you branch from there you should get a clean PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configure: WARNING: unrecognized options: --with-compiler
2 participants
@lyokha @andreasabel