Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: include libnetwork for haiku support #23

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

jessicah
Copy link
Contributor

@jessicah jessicah commented Jun 9, 2023

No description provided.

@jessicah
Copy link
Contributor Author

jessicah commented Jun 9, 2023

Will probably also need backporting.

@andreasabel
Copy link
Member

Will probably also need backporting.

@jessicah Thanks for the PR. What should this change be backported to?

@jessicah
Copy link
Contributor Author

I'm pretty sure I've seen 0.1.2.0 selected by cabal in a couple of instances instead of 2.0.1 whilst building various libraries.

@andreasabel
Copy link
Member

I'm pretty sure I've seen 0.1.2.0 selected by cabal in a couple of instances instead of 2.0.1 whilst building various libraries.

NB: 2.0.1 -> 0.2.0.1
Ah I see what you mean. In most cases, older major versions are not maintained, so without special requests we wouldn't do it here either. Users should add lower bound resolv >= 0.2 to their build-depends if they want to utilize this fix, this would be default procedure.

@andreasabel
Copy link
Member

@lyokha : Shall we release this as 0.2.0.2? I checked it locally on macOS.
I don't remember: is Windows supported at all? If yes, we should add some CI for it.

@lyokha
Copy link
Collaborator

lyokha commented Jun 10, 2023

@andreasabel, I would even release this as 0.2.1.0 as adding support for a new OS is a fair new feature. But I have a question to @jessicah. I'm not familiar with Haiku but its docs say that libnetwork is combined from libsocket and libbind. Supposedly, libbind is what really needed for resolv, but it's already checked by configure. So, the question is: do we really need adding libnetwork to configure when we already check libbind?

@jessicah
Copy link
Contributor Author

@lyokha ah, the wording is a bit weird there. libnetwork is the equivalent of those two libraries on Haiku. Haiku doesn't have libsocket or libbind.

@lyokha
Copy link
Collaborator

lyokha commented Jun 11, 2023

@jessicah, thank you for clarifying this! @andreasabel, regarding Windows, I don't know if it's supported.

@andreasabel
Copy link
Member

I think Haskell PVP would allow a patch release (0.2.0.2) here since the API did not change, we merely fixed a problem.
Or is it that this change could make installation fail where it succeeded before? Then we would need a major bump to 0.3.

@jessicah
Copy link
Contributor Author

No, I don't believe it would cause a failure from a previous success, as libnetwork would be a) tested last, and b) only succeed if it contained that symbol. And similar patches to configure scripts have been upstreamed for years now ;-)

@lyokha
Copy link
Collaborator

lyokha commented Jun 11, 2023

I'm not sure what version this should be, 0.2.0.2 seems also good.

@andreasabel
Copy link
Member

I tried installation on windows; it fails with configure: error: required <resolv.h> header not found. So I guess we do not have to worry about Windows.

@andreasabel
Copy link
Member

@andreasabel andreasabel self-assigned this Jun 11, 2023
@lyokha
Copy link
Collaborator

lyokha commented Jun 12, 2023

@andreasabel, do not forget to autoreconf - i in the working directory to generate a proper configure before making a dist

@andreasabel andreasabel merged commit 0b29460 into haskell-hvr:master Jun 12, 2023
11 checks passed
@andreasabel
Copy link
Member

Ok, published as 0.2.0.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants