Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMU: postgresql-simple #155

Closed
phadej opened this issue May 10, 2018 · 7 comments
Closed

NMU: postgresql-simple #155

phadej opened this issue May 10, 2018 · 7 comments
Labels

Comments

@phadej
Copy link
Member

phadej commented May 10, 2018

Release was asked for lpsmith/postgresql-simple#252 explicitly on Mar 31,

I also made a few small .cabal adjustments in a PR lpsmith/postgresql-simple#253

@phadej phadej added the NMU label May 10, 2018
@phadej
Copy link
Member Author

phadej commented May 10, 2018

Sent an email to Leon. This starts a countdown.

@phadej
Copy link
Member Author

phadej commented May 18, 2018

Emailed Leon again. Will do NMU on Friday 25.5 if there are no reply.

I'll prepare release on Monday/Tuesday. Are there any volunteers to review?

@gwils
Copy link
Contributor

gwils commented May 20, 2018

I'm happy to review.

@phadej
Copy link
Member Author

phadej commented May 23, 2018

@gwils I set up a branch

lpsmith/postgresql-simple@v0.5.3.0...hackage-trustees:release-0.5.4.0

Travis build: https://travis-ci.org/hackage-trustees/postgresql-simple/builds/382566872

This is the text I intent to tag the release with:

GHC-8.4 support

This is (going to be) Non-Maintainer Upload, therefore only
necessary changes are included compared to 0.5.3.0.

At the moment of writing, there are breaking changes in the `master` branch also,
for example move to use `Only` package.

Included changes are cherry-picked from master:
- Compatibility with Semigroup/Monoid proposal by Ben Gamari
- Add some lower-bounds by Oleg Grenrus

In addition there are small changes to .cabal file:
- `cabal.version: >= 1.10`:
    - added `default-language: Haskell2010`
    - changed `extensions` to `default-extensions`
- `tested-with` field with GHC 7.6.3 ... 8.4.2
- `source-repository this` points to `hackage-trustees` repository

@gwils
Copy link
Contributor

gwils commented May 24, 2018

The diff looks good to me, and it builds as far back as 7.6 on my machine.
I have some small recommendations for your tag message:

GHC-8.4 support

This is (going to be) a Non-Maintainer Upload, therefore only
necessary changes are included compared to 0.5.3.0.

At the moment of writing, there are breaking changes in the `master` branch also,
for example moving to use `Only` package.

Included changes are cherry-picked from master:
- Compatibility with Semigroup/Monoid proposal by Ben Gamari
- Add some lower-bounds by Oleg Grenrus

In addition there are small changes to .cabal file:
- `cabal.version: >= 1.10`:
    - added `default-language: Haskell2010`
    - changed `extensions` to `default-extensions`
- `tested-with` field with GHC 7.6.3 ... 8.4.2
- `source-repository this` points to `hackage-trustees` repository

@phadej
Copy link
Member Author

phadej commented May 24, 2018

@gwils thanks!

@phadej
Copy link
Member Author

phadej commented May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants