Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-distance and GHC 7.10 #19

Closed
bergmark opened this issue Apr 8, 2015 · 7 comments
Closed

edit-distance and GHC 7.10 #19

bergmark opened this issue Apr 8, 2015 · 7 comments

Comments

@bergmark
Copy link
Member

bergmark commented Apr 8, 2015

Matrix build before revisions: http://164.138.31.15/matrix/edit-distance.html
I added upper bounds on base.

A PR was opened 9 days ago to add GHC 7.10 compatibility: batterseapower/edit-distance#3 , The fix is backwards-compatible, enabling FlexibleContexts in one module.

Opening this seeing as we did an NMU for another package by @batterseapower and he still shows no github activity.

@bergmark
Copy link
Member Author

I sent an e-mail to Max.

@gbaz
Copy link
Contributor

gbaz commented May 3, 2015

ok i think we're ok to do an nmu on this now?

@bergmark
Copy link
Member Author

bergmark commented May 3, 2015

Yes, I forgot to say that I sent another e-mail to Max a week ago saying we'd do an NMU. I'll prepare the fix.

@bergmark
Copy link
Member Author

bergmark commented May 3, 2015

batterseapower/edit-distance@master...hackage-trustees:master

Tested on GHC-7.0 through 7.10.

Trustee review please!

@hvr
Copy link
Contributor

hvr commented May 4, 2015

LGTM

@hesselink
Copy link

I've added you as a maintainer, so you can do the upload.

@bergmark
Copy link
Member Author

bergmark commented May 4, 2015

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants