hnix-store-{core,remote}: allow also base16-bytestring < 1.0
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
changed the title
base16-bytestring < 1.0 alsobase16-bytestring < 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first tried to fork & overload the
cryptohash-sha512incabal.project, I enforced thebase16-bytestring >= 1.0requirement, that I encountered in HNix, and understood that the support of both epochs is very easy incryptohash-sha512and HNix-Store with a couple of lines of CPP macros.So this is what this PR does. Allows downstream to use any version of
base16-bytestring, the same probably would be done in HNix.This also simplifies things with Nixpkgs, as standard
base16-bytestringthere is0.1.1.7, so supporting both means Store works in Nixpkgs in any case.