add a readonly computeStorePathForPath

[layus]

No description provided.

[layus]

It seems that it does not work correclty, for now. I do not get the right hash in the end :-/

[layus]

Fixed in #145 🎉

[layus]

I do not understand why I need AllowAmbiguousTypes and TypeFamilies here. Looks way overkill for that simple function.

[layus]

Just to give an idea of what I am facing now:

src/System/Nix/ReadonlyStore.hs:76:28: error:
    • Could not deduce (NamedAlgo a0)
      from the context: NamedAlgo a
        bound by the type signature for:
                   computeStorePathForPath :: forall (a :: HashAlgorithm).
                                              NamedAlgo a =>
                                              StorePathName
                                              -> FilePath
                                              -> Bool
                                              -> (FilePath -> Bool)
                                              -> Bool
                                              -> IO StorePath
        at src/System/Nix/ReadonlyStore.hs:(76,28)-(82,26)
      The type variable ‘a0’ is ambiguous
    • In the ambiguity check for ‘computeStorePathForPath’
      To defer the ambiguity check to use sites, enable AllowAmbiguousTypes
      In the type signature:
        computeStorePathForPath :: forall a.
                                   (NamedAlgo a) =>
                                   StorePathName
                                   -> FilePath -> Bool -> (FilePath -> Bool) -> Bool -> IO StorePath
   |
76 | computeStorePathForPath :: forall a. (NamedAlgo a)
   |                            ^^^^^^^^^^^^^^^^^^^^^^^...

[layus]

Fixed everything :-). I think it is ready
@sorki Would you consider reviewing it ?

[sorki]

Fixed superfluous parens here and pushed to master.

[sorki]

Thank you!

[layus]

I copied the style from makeStorePath above :-) Le 24 mars 2021 09:22:12 GMT+01:00, Richard Marko ***@***.***> a écrit : ***@***.*** commented on this pull request.

…

> @@ -45,9 +47,7 @@ makeTextPath fp nm h refs = makeStorePath fp ty h nm makeFixedOutputPath :: forall hashAlgo - . ( ValidAlgo hashAlgo - , NamedAlgo hashAlgo - ) + . (NamedAlgo hashAlgo) Fixed superfluous parens here and pushed to master. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #144 (review)

[sorki]

I feel like we should do something about these two arguments but I'm not sure what.

[sorki]

Oops, I'm opening style can of worms discussion. Wanted to do that anyway, maybe we can ormolu everything and forget about such.

[layus]

maybe we can everything and forget about such.

Yes, I spend a lot of time indenting, formatting and similarly torturing myself to get formatting right, even though I do not have any strong opinion on the right formatting. Any automated tool would get rid of this wasted time.