Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Generic1 instance for NKeyName is incorrect #225

Closed
jwiegley opened this issue Apr 26, 2018 · 5 comments
Closed

The Generic1 instance for NKeyName is incorrect #225

jwiegley opened this issue Apr 26, 2018 · 5 comments
Labels
help wanted When someone explicitly requests for help

Comments

@jwiegley
Copy link
Member

No description provided.

@jwiegley jwiegley added the help wanted When someone explicitly requests for help label Apr 26, 2018
@jwiegley jwiegley modified the milestone: BayHac 2018 Apr 26, 2018
@expipiplus1
Copy link
Collaborator

Is it possible to at least remove the instance, it's quite confusing to come across it like this!

@expipiplus1
Copy link
Collaborator

expipiplus1 commented Oct 22, 2020 •
edited

This may be useful for anyone wanting to use NKeyName somewhat generically (Although these don't have Generic1 instances):

Antiquoted (NString r) r = Antiquoted (NString r) (Identity r)
                         = Biff Antiquoted NString Identity r r
                         = Join (Biff Antiquoted NString Identity) r

@jwiegley
Copy link
Member Author

If it still builds and passes tests without it, can you please submit a PR? Seems like a simple enough thing to merge.

expipiplus1 added a commit to expipiplus1/hnix that referenced this issue Oct 23, 2020
@expipiplus1
Remove Generic1 instance for NKeyName
49b71cc 
See haskell-nix#225
@expipiplus1 expipiplus1 mentioned this issue Oct 23, 2020
Merged
@expipiplus1
Copy link
Collaborator

Done, thanks

jwiegley pushed a commit that referenced this issue Oct 27, 2020
@expipiplus1 @jwiegley
Remove Generic1 instance for NKeyName
4202bac 
See #225
@jwiegley
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted When someone explicitly requests for help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwiegley @expipiplus1