Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation on Hackage #538

Closed
sjakobi opened this issue Mar 14, 2020 · 13 comments
Closed

Missing documentation on Hackage #538

sjakobi opened this issue Mar 14, 2020 · 13 comments
Labels
bug documentation Art of how not to explain.

Comments

@sjakobi
Copy link
Member

sjakobi commented Mar 14, 2020

Neither 0.7.0 nor 0.7.1 show haddocks on Hackage.

I suspect the problem are these build failures: http://hackage.haskell.org/package/hnix-0.7.1/reports/

main/Repl.hs:64:36: error:
    Ambiguous occurrence ‘options’
    It could refer to either ‘System.Console.Repline.options’,
                             imported from ‘System.Console.Repline’ at main/Repl.hs:56:1-39
                          or ‘Repl.options’, defined at main/Repl.hs:204:1
   |
64 |     $ evalRepl (return prefix) cmd options (Just ':') completer welcomeText
   |                                    ^^^^^^^

main/Repl.hs:221:48: error:
    Ambiguous occurrence ‘options’
    It could refer to either ‘System.Console.Repline.options’,
                             imported from ‘System.Console.Repline’ at main/Repl.hs:56:1-39
                          or ‘Repl.options’, defined at main/Repl.hs:204:1
    |
221 |   mapM_ putStrLn $ map (\o -> ":" ++ (fst o)) (options @e @t @f @m)
    |                                                ^^^^^^^
@sjakobi
Copy link
Member Author

sjakobi commented Mar 27, 2020

#540 addresses the build failure.

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented May 25, 2020

It seems like: #580 already solved Haddock issue.

Its branch:
upd-HNix-store-0.2: GHC 8.6.5, nix-shell:

cabal v2-haddock
...
Documentation created:
/home/pyro/src/haskell/hnix/dist-newstyle/build/x86_64-linux/ghc-8.6.5/hnix-0.7.1/doc/html/hnix/index.html

cabal haddock
...
Documentation created:
/home/pyro/src/haskell/hnix/dist-newstyle/build/x86_64-linux/ghc-8.6.5/hnix-0.7.1/doc/html/hnix/index.html

Anton-Latukha added a commit to Anton-Latukha/hnix that referenced this issue May 25, 2020
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented May 25, 2020

I've understood that Repl.hs is not in the build loop.
#582 should solve this. I've looked a bit into the usage of HaskellineT/Repline Hackage modules in main/Repl.hs other things seem not collide.

We should think how to include these files in the REPL IDE loop, so we can work on them.

@Anton-Latukha
Copy link
Collaborator

So to battle test fixes the Hackage prerelease is needed.

Soon we would be able to test this in CI.

@sjakobi
Copy link
Member Author

sjakobi commented May 28, 2020

The original issue has already been fixed in #582. Thanks again, @Anton-Latukha! :)

If there's more to do in this context, let's better track that in a different issue.

@sjakobi sjakobi closed this as completed May 28, 2020
@Anton-Latukha
Copy link
Collaborator

There is a CI option ready to track these. Ther is the option (even several) to test full proper packaging.

@Anton-Latukha Anton-Latukha reopened this May 29, 2020
Documentation and guidelines automation moved this from To do to In progress May 29, 2020
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented May 29, 2020

There are still no docs in 0.8.

That means we need to merge the CI, enable package testing and get on it.

@sjakobi
Copy link
Member Author

sjakobi commented May 30, 2020

Hackage currently reports that the docs build for hnix-0.8.0 is still in progress:

image

However I don't expect it to succeed, since it already fails to build docs for hnix-store-core and saltine: haskell-nix/hnix-store#65

We'll have to upload Haddocks manually for now. @jwiegley, could you take care of that, or give one of us permission to do it, i.e. add a maintainer on Hackage?

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Jun 2, 2020

Related #612, I've tried buildFromSdist and that is what resolves into.

@jwiegley
Copy link
Member

jwiegley commented Jun 7, 2020

@sjakobi I've added you as a Hackage maintainer for hnix. @Anton-Latukha What is your user id so that I may add you as well?

@Anton-Latukha
Copy link
Collaborator

@jwiegley Yes, I created the account AntonLatukha, received Hackage upload permissions, and would read-up upon Hackage docs.

@jwiegley
Copy link
Member

@Anton-Latukha You're now a maintainer of hnix on Hackage, and can upload releases. Thank you!

@sjakobi
Copy link
Member Author

sjakobi commented Jun 13, 2020

I have found a bit of documentation on the manual docs upload here (see the "Notes" section at the bottom of the page):

http://hackage.haskell.org/upload

I've taken care of the missing docs for 0.7.0, 0.7.1 and 0.8.0 for now. I assume we'll have to do the manual upload with each release as long as hnix-store-core requires the libsodium system dependency (haskell-nix/hnix-store#66).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Art of how not to explain.
Development

No branches or pull requests

3 participants