Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String: improve function names #1039

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Anton-Latukha
Copy link
Collaborator

No description provided.

@soulomoon
Copy link
Collaborator

soulomoon commented Feb 10, 2022

looking good to me, such rename make functionality more clear in such big project.

@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Feb 10, 2022

After the statement (in 0.18), that I moved all getterts to get* suffix, - I still find getters that do not follow that style.

In the codebase there is a difficulty between that there are several String* & several Context* which are used close or in conjunction in the code and function names/getters did not entail the difference and it is hard to transmit the difference.

This PR currently is just a code save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants