-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid bytestring
>= 0.11 with GHC < 8.0
#16
Avoid bytestring
>= 0.11 with GHC < 8.0
#16
Conversation
0895370
to
8c0b87c
Compare
Pushed an update for Cabal < 2.2, older Cabal versions don't support |
I'm going to get better CI going with this repo, and then we can run this PR through it. |
MASTER has been updated to use haskell-ci, a more automatic and consistent way of handling travis ci for haskell projects. more and more core libraries are moving toward using haskell-ci, and i think haskell-streaming should too. |
@fosskers to answer your question about github ci, i would consider using it if there were an automated/stable way of setting it up. don't know of one (haven't googled and about to run out the door). additionally, the core libraries convering on using haskell-ci + travis makes it particularly attractive to me. let me know if you have any thoughts. |
Most recent master now builds with the new CI: https://travis-ci.org/github/haskell-streaming/streaming-bytestring |
I happen to have written about it: https://www.fosskers.ca/en/blog/github-ci What I like about it is that it is fairly minimal, and has first-class support from the Github UI. |
@vdukhovni can you rebase this onto |
In `bytestring` 0.11 the `PS` constructor becomes a pattern synonym, only available with GHC >= 8.0. Since this package depends on `bytestring` internals, and in particular the `PS` constructor, with GHC < 8.0 it must stick to older bytestring releases. With GHC >= 8.0, this package will be compatible with the imminent `bytestring` 0.11, so the dependency ceiling is for now set to < 0.12.
8c0b87c
to
e9a0b96
Compare
Done, I rebased both this PR and #18. |
Alright, CI is now testing a huge range of GHCs (including the ones relevant to this PR), and things look good, so let's get this in. Thanks for this! |
You're welcome. I should perhaps mention that in late-breaking news GHC 9.0 will require at least http |
In
bytestring
0.11 thePS
constructor becomes a pattern synonym, onlyavailable with GHC >= 8.0. Since this package depends on
bytestring
internals, and in particular the
PS
constructor, with GHC < 8.0 it muststick to older bytestring releases.
With GHC >= 8.0, this package will be compatible with the imminent
bytestring
0.11, so the dependency ceiling is for now set to < 0.12.