Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings #95

Closed
UnkindPartition opened this issue Apr 14, 2014 · 3 comments
Closed

Enable warnings #95

UnkindPartition opened this issue Apr 14, 2014 · 3 comments

Comments

@UnkindPartition
Copy link
Member

We should enable warnings as much as it makes sense. Esp. -fwarn-incomplete-patterns. #94 would have been caught by it.
@UnkindPartition
Copy link
Member Author

-fwarn-incomplete-patterns is now enabled by default. There's still value in enabling other warnings and making them pass.

@pjonsson
Copy link
Contributor

pjonsson commented Jun 6, 2014

We now build with -Wall by default and I have no warnings with ghc 7.6.3 on my builds. Is this issue fixed, or do you have other warnings in mind?

@UnkindPartition
Copy link
Member Author

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@UnkindPartition @pjonsson