Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new curves (e.g Ed25519 and Ed448) #309

Closed
kazu-yamamoto opened this issue Nov 13, 2018 · 4 comments
Closed

new curves (e.g Ed25519 and Ed448) #309

kazu-yamamoto opened this issue Nov 13, 2018 · 4 comments

Comments

@kazu-yamamoto
Copy link
Collaborator

@ocheron Is https://github.com/ocheron/hs-tls/tree/newcurves ready for merging?
This conflicts with #298. In my impression, we should merge newcuves (and downgrade-protection) first then tackle #298.

@kazu-yamamoto
Copy link
Collaborator Author

@ocheron @vdukhovni Here is an example of merge plan for downgrade-protection, newcurves and tls13-client-auth: https://github.com/kazu-yamamoto/hs-tls/tree/proj

Maybe the code is redandant but all test cases pass.

@kazu-yamamoto kazu-yamamoto changed the title new curves new curves (e.g Ed25519 and Ed448) Nov 14, 2018
@kazu-yamamoto
Copy link
Collaborator Author

Ping @ocheron
Would you tell me the status of newcurves?
If it takes time, I will merge #298 first.

@ocheron
Copy link
Contributor

ocheron commented Nov 19, 2018

Would you tell me the status of newcurves?

This is basically my work from 2017 without ECDSA, and rebased on top of TLS13.
Will need to go through PR and review. HEAD is moving fast but rebase is still clean it seems.

@kazu-yamamoto
Copy link
Collaborator Author

OK. I will merge #298 first. newcurves will conflict with the new master.
You can see how to resolve the conflict in https://github.com/kazu-yamamoto/hs-tls/tree/proj though the merge ordering is flipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants