-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding states and parameters for TLS 1.3 #280
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
158328f
defining Established.
kazu-yamamoto f565099
adding new functions.
kazu-yamamoto 0962a6a
adding EarlyData.
kazu-yamamoto 20c1259
new structures and states for TLS 1.3.
kazu-yamamoto 030ed58
new handshake states for TLS 1.3.
kazu-yamamoto 66e6859
extending sessionData.
kazu-yamamoto 8465ab4
adding sessionResumeOnlyOnce to SessionManager.
kazu-yamamoto 4c686f1
adding ctxPendingActions to Context.
kazu-yamamoto d77e809
adding infoIsEarlyDataAccepted to Information.
kazu-yamamoto 0a05f3e
adding RSA PSS to supportedHashSignatures.
kazu-yamamoto 2c4a609
removing NoEarlyData because AcceptEarlyData 0 means the same.
kazu-yamamoto de9ae0f
using Int for sessionMaxEarlyDataSize.
kazu-yamamoto f203f2f
updating doc.
kazu-yamamoto edb60db
using ShowS for Show TLS13TicketInfo.
kazu-yamamoto 4096e51
fixing doc.
kazu-yamamoto 2ee7127
Adding early-data field to ServerParams and ClientParams instead of E…
kazu-yamamoto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean sendData and recvData are possible in all 3 other states?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For TLS 1.2 or earlier and clients of TLS 1.3, only
Established
andNotEstablished
are used.For servers of TLS 1.3,
sendData
can be used only onEstablished
.recvData
can be used on eitherEstablished
orEarlyDataAllowed
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are concerned about this, let's come back to this issue after the entire merge process is finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see the coming patches on https://github.com/kazu-yamamoto/hs-tls/tree/work13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK we can see checkValid later.