TLSv1.3 UserCanceled Event #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Jun 28, 2023
|
Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLSv1.3 closure event message
user_canceledis unhandled, which will currently throw an exception as it will fall through to the "unexpected message" function clause here: https://github.com/haskell-tls/hs-tls/blob/ad16bdd849e594a8a429857dccefcd725a4d0d45/core/Network/TLS/Core.hs#LL186C1-L187C1https://datatracker.ietf.org/doc/html/rfc8446#page-87
The spec reads as this message is informational and so I have left the handling code as a no-operation, just consuming the event. Perhaps a better approach would be to permit the user to override this.