-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Exception instance for TLSError, bump to 1.8.0 #457
Conversation
Stop throwing TLSError and IOException to make it the exceptions thrown by this library more predicatable.
Also, I think we should let this sit for a while to see if there is any feedback about how this may negatively affect users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks lovely.
I will release v1.7.1 first then merge this PR into master
.
Merged. |
Done. |
A test case of |
In the longer term, My fear is that, if the |
I agree. |
For |
@andrewthad Please give a look at kazu-yamamoto/http-client@73d1a4e. If this is OK with you, I will send a PR to |
@andrewthad Gentle ping. |
Sorry, I hadn't noticed the command asking me to look at the |
@andrewthad New versions of |
v1.8.0 has been released. |
Stop throwing TLSError and IOException to make it the exceptions thrown by this library more predicatable.
Resolves #456