Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Extra.Cipher is not necessary anymore #471

Merged
merged 3 commits into from
May 22, 2024

Conversation

kazu-yamamoto
Copy link
Collaborator

  • setting supportedCiphers to ciphersuite_default
  • ciphersuite_default is now the same as ciphersuite_strong

See kazu-yamamoto/crypton-connection#3

@bfrk
Copy link

bfrk commented May 21, 2024

Much appreciated change, thanks. But surely incompatible, so next release will be 2.1 or 2.1.0, correct?

@kazu-yamamoto
Copy link
Collaborator Author

I'm not sure that this is an incompatible change.
Currently, everyone overrides the value.
So, no body notice this change.

@bfrk
Copy link

bfrk commented May 21, 2024

Hm. Technically it is a change in semantics. You are arguing that since the old default is not only trivial but actually useless, nobody is relying on it. That may well be true, but it is not a certainty, so I'd rather err on the side of caution. Anyway, it's your decision to make.

@kazu-yamamoto kazu-yamamoto merged commit fd28046 into haskell-tls:main May 22, 2024
9 checks passed
@kazu-yamamoto kazu-yamamoto deleted the better-default branch May 22, 2024 04:11
@kazu-yamamoto
Copy link
Collaborator Author

Merged.
I will release v2.0.6 very soon.

@bfrk
Copy link

bfrk commented May 22, 2024

ありがとうございます

@kazu-yamamoto
Copy link
Collaborator Author

どういたしまして。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants