Add ulid support
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
approved these changes
Feb 29, 2024
src/Data/RdsData/Internal/Convert.hs
Outdated
| textToUlid :: Text -> Either Text ULID | ||
| textToUlid t = | ||
| case ULID.decode 26 t of | ||
| (n, ""):_ -> ULID.ulidFromInteger n |
There was a problem hiding this comment.
Shouldn't we be pattern matching on the singleton list? Although it's only possible for this function to return []or [val].
There was a problem hiding this comment.
I switched the code to use the Read instance with avoids having to deal with the list.
newhoggy
force-pushed
the
newhoggy/add-ulid-support
branch
from
c1b3d6f
to
1f9f9d1
Compare
newhoggy
force-pushed
the
newhoggy/add-ulid-support
branch
from
1f9f9d1
to
1a3e34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.