Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GHC-9.2 #124

Merged
merged 9 commits into from May 8, 2022
Merged

Compatibility with GHC-9.2 #124

merged 9 commits into from May 8, 2022

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Apr 30, 2022

This patch enables compatibility with GHC 9 and GHC 9.2

@TeofilC
Copy link
Contributor Author

TeofilC commented Apr 30, 2022

Oh I didn't see #117 feel free to close this. Though the one thing missing from that is allowing template-haskell=2.18

@maoe
Copy link
Member

maoe commented May 2, 2022

Thanks! I think we can close #117 in favor of this PR.

I wonder why GitHub Actions didn't run.

@maoe maoe mentioned this pull request May 2, 2022
@TeofilC
Copy link
Contributor Author

TeofilC commented May 2, 2022

I think this line is blocking actions from running on PRs :

# - pull_request

@maoe
Copy link
Member

maoe commented May 2, 2022

Good catch! I forgot we had that. Could you uncomment it to run the CI?

@TeofilC
Copy link
Contributor Author

TeofilC commented May 2, 2022

It looks like that's done it now you just have to approve the workflow

@maoe
Copy link
Member

maoe commented May 2, 2022

Could you also add GHC 9.x to the Windows job?

@TeofilC
Copy link
Contributor Author

TeofilC commented May 3, 2022

I've added the windows jobs. I also tried to fix the builds of old GHCs, but I couldn't figure it out. It seems like the custom setup for glib depends on an old version of Cabal, but adding a Cabal >= 3.0.0 constraint to the solver doesn't seem to fix it. I imagine there's something weird going on because it's being depended on via a custom Setup

@maoe
Copy link
Member

maoe commented May 6, 2022

Thanks for taking a look at the CI failures. I'll also take a look hopefully later today.

@maoe
Copy link
Member

maoe commented May 6, 2022

I could reproduce the error like this:

ghcup install cabal 3.6.2.0
cabal update
cabal get glib
cd glib-0.13.8.2
cabal build -w ghc-8.6 -O0

Changing the cabal-version field in glib.cabal from 3.0 to 2.2 or 2.4 seems to fix the issue for some reason but I don't really understand why. I guess we can just drop support for ghc < 8.8. What do you think? @Mikolaj

@Mikolaj
Copy link
Member

Mikolaj commented May 6, 2022

I guess we can just drop support for ghc < 8.8. What do you think? @Mikolaj

Absolutely, such GHCs are ~5 years old already. And custom setups are now frowned upon and avoided in most cases, so not much sense to diagnose.

@maoe
Copy link
Member

maoe commented May 7, 2022

Alright, thanks!

@TeofilC Could you update the tested-with field and the CI config to drop GHC < 8.8?

@TeofilC
Copy link
Contributor Author

TeofilC commented May 7, 2022

Sure. Should be done in 4e7965c

@maoe
Copy link
Member

maoe commented May 8, 2022

LGTM. Thanks!

I'll upload a new version later today.

@maoe maoe merged commit 8401e80 into haskell:master May 8, 2022
@TeofilC
Copy link
Contributor Author

TeofilC commented May 8, 2022

Thanks!

@TeofilC TeofilC deleted the ghc-9.2-compat branch May 8, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants