New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with GHC-9.2 #124
Conversation
GHC no longer allows a space here
Oh I didn't see #117 feel free to close this. Though the one thing missing from that is allowing template-haskell=2.18 |
Thanks! I think we can close #117 in favor of this PR. I wonder why GitHub Actions didn't run. |
I think this line is blocking actions from running on PRs : ThreadScope/.github/workflows/ci.yml Line 3 in 8f51f5c
|
Good catch! I forgot we had that. Could you uncomment it to run the CI? |
It looks like that's done it now you just have to approve the workflow |
Could you also add GHC 9.x to the Windows job? |
I've added the windows jobs. I also tried to fix the builds of old GHCs, but I couldn't figure it out. It seems like the custom setup for glib depends on an old version of Cabal, but adding a |
Thanks for taking a look at the CI failures. I'll also take a look hopefully later today. |
I could reproduce the error like this:
Changing the cabal-version field in glib.cabal from 3.0 to 2.2 or 2.4 seems to fix the issue for some reason but I don't really understand why. I guess we can just drop support for ghc < 8.8. What do you think? @Mikolaj |
Absolutely, such GHCs are ~5 years old already. And custom setups are now frowned upon and avoided in most cases, so not much sense to diagnose. |
Alright, thanks! @TeofilC Could you update the tested-with field and the CI config to drop GHC < 8.8? |
Sure. Should be done in 4e7965c |
LGTM. Thanks! I'll upload a new version later today. |
Thanks! |
This patch enables compatibility with GHC 9 and GHC 9.2