Do not include windows_cconv.h on non mingw32 systems #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. I will merge if nobody objects. |
maoe
requested changes
Nov 11, 2017
GUI/GtkExtras.hs
Outdated
| #include "windows_cconv.h" | ||
| #endif |
There was a problem hiding this comment.
Can you flip the condition like this? It's easier to read.
#if mingw32_HOST_OS || mingw32_TARGET_OS
#include "windows_cconv.h"
#else
import ...
#endif
Do not include windows_cconv.h on non windows systems, or else build fails with `#error Unknown mingw32 arch` on architectures other than i386 or x86_64.
iliastsi
force-pushed
the
no-windows-cconv
branch
from
782e326
to
b8122e1
Compare
|
LGTM, thanks! As for the Travis failures, they seem irrelevant to this PR.
I'll fix above in a separate PR when I have time. |
maoe
approved these changes
Nov 13, 2017
|
Party! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include windows_cconv.h on non windows systems, or else build
fails with
#error Unknown mingw32 archon architectures other thani386 or x86_64.
This causes ThreadScope to fail to build on architectures other than i386 or x86_64.
As an example, see the build logs on arm64.