Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Use ghcup to install cabal head #290

Merged
merged 6 commits into from Oct 2, 2023

Conversation

nlander
Copy link
Contributor

@nlander nlander commented Aug 11, 2023

This allows head to be the specified cabal version.

@andreasabel
Copy link
Member

Thanks.

To evaluate the PR, please add a test to .github/workflows.
Once you are happy, please document the new feature in setup/README.

@andreasabel andreasabel added the re: cabal On setting up cabal label Aug 11, 2023
@nlander
Copy link
Contributor Author

nlander commented Aug 14, 2023

@andreasabel I have added a test and updated the README. I haven't run the test locally, because as far as I can tell it isn't part of the push hook. Please let me know if there is more I can do to help get this merged. Thanks!

@nlander
Copy link
Contributor Author

nlander commented Aug 14, 2023

@andreasabel I'm hoping these last two commits have fixed the test.

@nlander
Copy link
Contributor Author

nlander commented Sep 18, 2023

@andreasabel please take another look at this when you have a moment. Is there anything else you think this needs before merging?

@ulysses4ever
Copy link
Contributor

@andreasabel indeed, cabal team would be delighted to have this feature merged.

@nlander thanks a lot for taking the time to prepare the patch!

@andreasabel andreasabel merged commit 77e8db1 into haskell:main Oct 2, 2023
1 check passed
@andreasabel
Copy link
Member

Thanks, I merged it here.

The commit 77e8db1 needs to be transfered to haskell-actions/setup still.

@andreasabel
Copy link
Member

I now opened this as a PR at the new home of the setup action:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
re: cabal On setting up cabal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants