Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc 9.8 #247

Merged
merged 7 commits into from
Oct 29, 2023
Merged

ghc 9.8 #247

merged 7 commits into from
Oct 29, 2023

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Oct 22, 2023

This addresses the -x-partial warning where feasible, using Data.List.NonEmpty. This is an incentive to move to GHC 8 which first had this module in base. Thus, GHC 7 will be dropped.

TODO:

  • Remove now redundant #ifs
  • Update the Win/Mac CI to GHC 9.8.1
  • Reorganize commits
  • Fix release date in CHANGELOG

Content:

  • gitignore TAGS file
  • v3.4.0.1: Address x-partial warning of GHC 9.8
  • Drop support for building with GHC 7
  • Drop legacy modules Map, Set, Sort
  • Drop CPP pertaining to GHC < 8

Candidate at: https://hackage.haskell.org/package/alex-3.4.0.1/candidate
Docs at: https://haskell-alex--247.org.readthedocs.build/en/247/

@andreasabel andreasabel added this to the 3.4.0.1 milestone Oct 22, 2023
@andreasabel andreasabel added pr: squash PR should be squashed upon merge build / install Concerning building and/or installing Alex pr: reorganize commits Commits needs reorganization before merge labels Oct 22, 2023
@andreasabel andreasabel self-assigned this Oct 22, 2023
@andreasabel andreasabel removed the pr: squash PR should be squashed upon merge label Oct 22, 2023
src/DFAMin.hs Outdated Show resolved Hide resolved
@andreasabel andreasabel added pr: preserve commits Commits should be merged as such and removed pr: reorganize commits Commits needs reorganization before merge labels Oct 22, 2023
@andreasabel
Copy link
Member Author

@Ericson2314 : If you want a quick look...

This PR raises to bar to build alex to GHC 8 for the sake of using Data.List.NonEmpty. The latter helps to properly address the new x-partial warnings for head and tail in GHC 9.8.
On the way, I could get rid of pre-containers legacy modules (Set, Map, Sort). We are using containers already so this is not a big step.
Not sure if anyone cares about GHC 7 builds. One could take an older version of alex if one wants to do archeology...

To commits are to be merged as such.
I'll merge and release then...

@andreasabel andreasabel merged commit ff4832e into master Oct 29, 2023
26 checks passed
@andreasabel andreasabel deleted the ghc-9.8 branch October 29, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / install Concerning building and/or installing Alex pr: preserve commits Commits should be merged as such
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant