Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict ByteString findIndices very costly #269

Closed
archaephyrryx opened this issue Aug 26, 2020 · 0 comments · Fixed by #270
Closed

Strict ByteString findIndices very costly #269

archaephyrryx opened this issue Aug 26, 2020 · 0 comments · Fixed by #270
Labels
performance
Milestone
0.11.0.0

Comments

@archaephyrryx
Copy link
Contributor

CR

The per-byte cost of the internal loop of Data.ByteString.findIndices is ~20x greater than that of Data.ByteString.findIndex. It iterates an expensive operation per-byte, rather than directly finding each individual index in an efficient way.

Will author a pull request shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
0.11.0.0
Development

Successfully merging a pull request may close this issue.

FindIndices optimized using findIndex and inlining archaephyrryx/bytestring
2 participants
@archaephyrryx @Bodigrim