Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.11.0.0 #268

Merged
merged 8 commits into from
Sep 17, 2020
Merged

Conversation

Bodigrim
Copy link
Contributor

I think we are good to go, but will wait until the next week to upload.
It would be nice to include #258 as well, if it is ready in time.

CC @vdukhovni @fumieval

@Bodigrim Bodigrim added this to the 0.11.0.0 milestone Aug 26, 2020
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of goodies merged in a short time! 👍

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@vdukhovni
Copy link
Contributor

vdukhovni commented Aug 26, 2020

@archaephyrryx has found a substantial performance bug in findIndices #269 . The fix is being tested now, and will shortly be a PR. I'd very much like to see the fix merged shortly. The bug, for example, degrades the throughput of lineSplit in streaming-bytestring by ~20x-30x. Please don't release 0.11 just yet...

@Bodigrim
Copy link
Contributor Author

@vdukhovni no problem, especially if it gets merged this week.

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Show resolved Hide resolved
@andrewthad
Copy link
Contributor

I like your rewording of the changelog entry for the change involving strlen.

@fumieval
Copy link
Contributor

Seems fine to me

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the changelog mention #284?

Changelog.md Outdated Show resolved Hide resolved
@vdukhovni
Copy link
Contributor

Should the changelog mention #284?

Though the affected users are the poor sods who might try to use an older bytestring with GHC 9.0, I think this is a good thing to note in the change log, which some might find more easily than the commit or another source.

Bodigrim and others added 8 commits September 15, 2020 20:31
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@Bodigrim
Copy link
Contributor Author

Updated again.
I would like to merge this on Thursday, tag as 0.11.0.0-rc1 and gather feedback over the weekend before proceeding to a release.

@vdukhovni
Copy link
Contributor

Updated again.
I would like to merge this on Thursday, tag as 0.11.0.0-rc1 and gather feedback over the weekend before proceeding to a release.

Looks good. Speaking of the deprecation change: asking users to use Data.ByteString.Internal.accursedUnutterablePerformIO instead of Data.ByteString.Internal.inlinePerformIO. Is there still reason to use the former rather than the unsafeDupablePerformIO in base? They both ultimately have the same effect, and I did not find noticeable performance differences between them... Do we still need Data.ByteString.Internal.accursedUnutterablePerformIO (for reasons other than backwards compatibility)? It too could be deprecated and removed in a later major release if unsafeDupablePerformIO works just as well.

@Bodigrim
Copy link
Contributor Author

@vdukhovni AFAIU it is mostly a matter of compatibility with base < 4.4, which do not provide unsafeDupablePerformIO.

@vdukhovni
Copy link
Contributor

@vdukhovni AFAIU it is mostly a matter of compatibility with base < 4.4, which do not provide unsafeDupablePerformIO.

Sounds plausible... If that's the case, we can deprecate accursedUnutterable... as soon as we drop support for GHC 7.0. Base 4.4 is GHC 7.2, dating back to Aug 2011, and 7.0 is from Nov 2010. So by this time next year, 7.2 will be a decade old.

I'd actually be tempted to do the deprecation of accursedUnatterable... now, any remaining 7.0 users can ignore the warning. We can then remove it in 0.12.

@Bodigrim
Copy link
Contributor Author

I do not want to deprecate it in a hurry, and it is really a high time for release.

@Bodigrim Bodigrim merged commit 96c9539 into haskell:master Sep 17, 2020
@Bodigrim Bodigrim deleted the release-0.11.0.0 branch September 17, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants