Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define stimes and sconcat for Builder explicitly #489

Closed
sjakobi opened this issue Feb 18, 2022 · 0 comments · Fixed by #650
Closed

Define stimes and sconcat for Builder explicitly #489

sjakobi opened this issue Feb 18, 2022 · 0 comments · Fixed by #650
Labels
performance pr-welcome

Comments

@sjakobi
Copy link
Member

sjakobi commented Feb 18, 2022 •
edited

So far, the Semigroup instances contains only a explicit definition of (<>). Explicit definitions of the other methods should perform better than the default ones.

#456 should be resolved first though. (Done)
clyring added a commit to clyring/bytestring that referenced this issue Jan 31, 2024
@clyring
Explicitly implement sconcat in Semigroup instances
5d1a2d7 
Since `stimes` was explicitly implemented in haskell#611:
Closes haskell#488. Closes haskell#489.
@clyring clyring mentioned this issue Jan 31, 2024
Merged
clyring added a commit that referenced this issue Feb 5, 2024
@clyring
Explicitly implement sconcat in Semigroup instances (#650)
502f2c1 
Since `stimes` was explicitly implemented in #611:
Closes #488. Closes #489.

(cherry picked from commit 93fdd3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance pr-welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly implement sconcat in Semigroup instances clyring/bytestring
1 participant
@sjakobi