Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytestring-0.11.5.1 (ghc-9.4.6) fails to build on Fedora #606

Closed
juhp opened this issue Aug 8, 2023 · 4 comments · Fixed by #607
Closed

bytestring-0.11.5.1 (ghc-9.4.6) fails to build on Fedora #606

juhp opened this issue Aug 8, 2023 · 4 comments · Fixed by #607

Comments

@juhp
Copy link

juhp commented Aug 8, 2023 •
edited

The recent change #604 seems to causes problems, at least on Fedora Linux, when building ghc-9.4.6:

===> Command failed with error code: 1
In file included from /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/rts-1.0.2/include/Rts.h:235,
                 from libraries/bytestring/cbits/is-valid-utf8.c:53:0: error:
    
/usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/rts-1.0.2/include/rts/OSThreads.h:38:5: error:
     error: unknown type name ‘clockid_t’
       38 |     clockid_t timeout_clk;
          |     ^~~~~~~~~
   |
38 |     clockid_t timeout_clk;
   |     ^
@juhp
Copy link
Author

juhp commented Aug 8, 2023 •
edited

Commenting out #include "Rts.h" allows the build to continue at least: still testing more.

https://github.com/haskell/bytestring/pull/604/files#r1286920457

@juhp
Copy link
Author

juhp commented Aug 8, 2023

This is being discussed in https://gitlab.haskell.org/ghc/ghc/-/issues/23789

clyring added a commit to clyring/bytestring that referenced this issue Aug 8, 2023
@clyring
Use a more specific include than Rts.h
4ab6475 
The Rts.h include seems to cause build problems.
See also:
  https://gitlab.haskell.org/ghc/ghc/-/issues/23789
  haskell#606
@clyring clyring mentioned this issue Aug 8, 2023
Merged
Bodigrim pushed a commit that referenced this issue Aug 8, 2023
@clyring
Use a more specific include than Rts.h (#607)
e8a9b52 
The Rts.h include seems to cause build problems.
See also:
  https://gitlab.haskell.org/ghc/ghc/-/issues/23789
  #606
clyring added a commit that referenced this issue Aug 8, 2023
@clyring
Use a more specific include than Rts.h (#607)
2bdeb7b 
The Rts.h include seems to cause build problems.
See also:
  https://gitlab.haskell.org/ghc/ghc/-/issues/23789
  #606

(cherry picked from commit e8a9b52)
@juhp
Copy link
Author

juhp commented Aug 9, 2023

I am still surprised the problem doesn't occur on Ubuntu:
I checked myself and indeed it builds with both 22.04 (8.8) and 23.04 (9.0).

@clyring clyring linked a pull request Aug 9, 2023 that will close this issue
Use a more specific include than Rts.h #607
Merged
@clyring
Copy link
Member

clyring commented Aug 9, 2023

Fixed in #607.

@clyring clyring closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a more specific include than Rts.h clyring/bytestring
2 participants
@juhp @clyring