Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function dropEnd #290

Merged
merged 12 commits into from
Oct 5, 2020
Merged

add function dropEnd #290

merged 12 commits into from
Oct 5, 2020

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Sep 30, 2020

This fixes the issue #119

Bodigrim
Bodigrim reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you possibly add takeEnd as well?

Data/ByteString.hs Outdated Show resolved Hide resolved
Data/ByteString.hs Outdated Show resolved Hide resolved
tests/Properties.hs Outdated Show resolved Hide resolved
@Cmdv
Copy link
Contributor Author

Cmdv commented Sep 30, 2020

@Bodigrim thanks for review, sorry I was meant to put this PR as Draft!
I'll make amends and add a takenEnd too.

Bodigrim
Bodigrim reviewed Sep 30, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
Data/ByteString.hs Outdated Show resolved Hide resolved
@Cmdv
Copy link
Contributor Author

Cmdv commented Oct 1, 2020

@Bodigrim just added some examples as always find those more intuitive (might add more through out in another PR if this style is ok).

Not 100% this is what you meant in regards to Could you please inline the definition of drop here

https://github.com/Cmdv/bytestring/blob/86ab7a397d471ec01d1bb9fa1500c4b723b9d35a/Data/ByteString.hs#L903-L912

Bodigrim
Bodigrim reviewed Oct 1, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
Bodigrim
Bodigrim reviewed Oct 1, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
Bodigrim
Bodigrim reviewed Oct 2, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
Bodigrim
Bodigrim reviewed Oct 3, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
sjakobi
sjakobi reviewed Oct 4, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
sjakobi
sjakobi reviewed Oct 4, 2020
View reviewed changes
Data/ByteString.hs Outdated Show resolved Hide resolved
Cmdv and others added 3 commits October 4, 2020 17:30
@Cmdv @sjakobi
Update Data/ByteString.hs
528b8f3 
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@Cmdv @sjakobi
fix monospace in docs
4975143 
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@Cmdv
remove usage of internal function in examples
e010139
sjakobi
sjakobi approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bodigrim Bodigrim linked an issue Oct 5, 2020 that may be closed by this pull request
Add new function: dropEnd #119
Closed
@Bodigrim Bodigrim added this to the 0.11.1.0 milestone Oct 5, 2020
@Bodigrim Bodigrim merged commit f004302 into haskell:master Oct 5, 2020
@Bodigrim
Copy link
Contributor

Bodigrim commented Oct 5, 2020

Thanks, @Cmdv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlix Vlix Vlix left review comments

@Bodigrim Bodigrim Bodigrim approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1.0
Development

Successfully merging this pull request may close these issues.

Add new function: dropEnd
4 participants
@Cmdv @Bodigrim @sjakobi @Vlix