Implement Data.ByteString.Lazy.compareLength #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Oct 8, 2020
|
Almost there! We can also benefit from rewrite rules, similar to Do not forget to re-export this function from |
gutjuri
commented
Oct 10, 2020
gutjuri
commented
Oct 10, 2020
gutjuri
changed the title
Bodigrim
approved these changes
Oct 10, 2020
sjakobi
reviewed
Oct 12, 2020
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
sjakobi
reviewed
Oct 15, 2020
|
@gutjuri merged, thanks! |
vdukhovni
reviewed
Oct 24, 2020
Comment on lines
+1427
to
+1432
| -- Required for rewrite rules for 'compareLength' | ||
| negateOrdering :: Ordering -> Ordering | ||
| negateOrdering LT = GT | ||
| negateOrdering EQ = EQ | ||
| negateOrdering GT = LT | ||
|
|
There was a problem hiding this comment.
This function looks redundant to me, it is just compare EQ.
There was a problem hiding this comment.
Should I open a miniature pull request to delete negateOrdering and replace its call site with compare EQ?
There was a problem hiding this comment.
Yes, much appreciated. Could you please also combine all rules for compareLength under a single RULES pragma?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #298
I tested the function in GHCi.
Unfortunately I do not yet understand how to add tests to the testsuite.
I'd be great if someone could give me a point in the right direction on where to add tests.
Concerning the documentation: I described the compareLength as being O(n) (where n is the length of the ByteString). This is a bit imprecise, because it neglects the
Intparameter entirely. However, I was not sure on how to refer to this parameter in the documentation.