Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafePackageLenAddress and unsafePackLenLiteral #390

Merged
merged 2 commits into from
May 31, 2021
Merged

Add unsafePackageLenAddress and unsafePackLenLiteral #390

merged 2 commits into from
May 31, 2021

Conversation

phadej
Copy link
Contributor

@phadej phadej commented May 22, 2021

No description provided.

@phadej phadej mentioned this pull request May 22, 2021
Merged
Bodigrim
Bodigrim approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can unsafePack{Address,Literal} be rewritten to compute length and call unsafePackLen{Address,Literal}? It would be nice not to duplicate this low-level stuff.

@phadej
Copy link
Contributor Author

phadej commented May 27, 2021 •
edited
Loading

Done, unfortunately length calculation needs CPP, so it's not much cleaner.

@phadej phadej mentioned this pull request May 30, 2021
Merged
@Bodigrim Bodigrim requested a review from sjakobi May 30, 2021 14:33
@Bodigrim Bodigrim merged commit eebbfdc into haskell:master May 31, 2021
@Bodigrim Bodigrim added this to the 0.11.2.0 milestone Jun 10, 2021
Bodigrim pushed a commit to Bodigrim/bytestring that referenced this pull request Jun 10, 2021
@phadej @Bodigrim
Add unsafePackageLenAddress and unsafePackLenLiteral (haskell#390)
214deb6
noughtmare pushed a commit to noughtmare/bytestring that referenced this pull request Dec 12, 2021
@phadej @noughtmare
Add unsafePackageLenAddress and unsafePackLenLiteral (haskell#390)
b816197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phadej @Bodigrim @sjakobi