Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ‘unsafeIndex’ on short bytestrings #532

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

sergv
Copy link
Contributor

@sergv sergv commented Jul 15, 2022

I noticed the function got removed in 731caea but there's no trace of that in the changelog, which probably makes it an accidental omission.

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the accidental removal is very unfortunate. I guess I should start using cabal-diff or something like that on larger releases.

This PR would be a candidate for a v0.11.3.2, I guess.

Changelog.md Outdated Show resolved Hide resolved
@sjakobi sjakobi requested a review from Bodigrim July 15, 2022 14:55
@Bodigrim
Copy link
Contributor

This PR would be a candidate for a v0.11.3.2, I guess.

It should rather be 0.11.4.0, I think.

@sjakobi do you have bandwidth to rebase this onto bytestring-0.11 branch and make a release in time for GHC 9.4.1?

@sjakobi
Copy link
Member

sjakobi commented Jul 23, 2022

@sjakobi do you have bandwidth to rebase this onto bytestring-0.11 branch and make a release in time for GHC 9.4.1?

I can do this next week.

@sjakobi sjakobi merged commit a729850 into haskell:master Jul 25, 2022
@sjakobi sjakobi added this to the 0.11.4.0 milestone Jul 25, 2022
sjakobi pushed a commit that referenced this pull request Jul 25, 2022
sjakobi pushed a commit that referenced this pull request Jul 25, 2022
milloni pushed a commit to milloni/bytestring that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants