Remove two bad accursedUnutterablePerformIO uses #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
approved these changes
Sep 17, 2022
|
Thanks @clyring! |
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Nov 25, 2022
Co-authored-by: Matthew Craven <clyring@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of these was demonstrated by haskell/aeson#967 and GHC issue 22204.
I took the liberty of auditing the rest of our use-sites for
accursedUnutterablePerformIO. The uses I haven't removed in this commit perform only read effects, which are at least less dangerous.