Remove support for ghc < 8.4 #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the way: * Obseleted CPP and compatibility workarounds were removed * Most remaining CPP conditions are moved into bytestring-cpp-macros.h and given specific feature names * Most imports from ghc-prim are replaced with equivalent imports from base * Data.ByteString.Builder.RealFloat.Internal is left untouched, to avoid unnecessary conflicts
Bodigrim
reviewed
Jun 8, 2024
| @@ -108,7 +109,7 @@ common language | |||
|
|
|||
| library | |||
| import: language | |||
| build-depends: base >= 4.9 && < 5, ghc-prim, deepseq, template-haskell | |||
| build-depends: base >= 4.11 && < 5, ghc-prim, deepseq, template-haskell | |||
There was a problem hiding this comment.
How far are we from dropping dependency on ghc-prim entirely? I'd be happy to drop more old GHCs if it helps.
There was a problem hiding this comment.
I think the remaining uses are all in the RealFloat Builder internals. I think it will be easiest to clean those up after #637 lands.
Bodigrim
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way: