Fixing warnings #240
Open
Fixing warnings #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar to the hackage one.
…d added ghc-8.5.6 - the version I was using.
|
I have figured out why the build is failing btw. It is due too a missing dependency in libssh2: |
|
@deech Why hasn't this PR gotten any attention? (Looks useful.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bunch of warnings here and there(thrown at me by a recent ghc). I was going to move this whole thing to a more recent version of cabal, but eventually ended up reverting everything back, to keep things nice and clear. I hope I didn't break anything. I commented some unused things instead of deleting them because they looked like some test cases, which never get called for some reason.