Update README #24
Merged
Update README #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srirajshukla
reviewed
Jul 3, 2021
README.md
Outdated
| @@ -13,7 +14,12 @@ run mdformat on your own. CI will fail if markdown files are not correctly | |||
| formatted! | |||
There was a problem hiding this comment.
It says 'run mdformat' here, shouldn't it be run Prettier?
There was a problem hiding this comment.
Good catch, updated
There was a problem hiding this comment.
Can we add a link for how to enable experimental features (if someone wants to)?
There was a problem hiding this comment.
Sure, I think that is kind of marginal (the docs here shouldn't be responsible for teaching someone how to use nix, they just offer a method of setting up the project for nix users) but I am happy to provide a link.
Mikolaj
approved these changes
Jul 3, 2021
emilypi
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.