suppress annoying missing haddock warning for whitelist (rts) #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a hardcoded whitelist of packages (currently 'rts') to not have haddocks. When building several packages together, the accumulation of these spurious warnings can make it a bit harder to notice legitimate errors.
|
@dcoutts, what do you think? |
|
Looks fine to me. The thing in cabal-install is about generating an index of all the packages you have installed. Yes, I guess there's some opportunity for sharing there. If anyone wants to do that, then follow the model we have for D.S.Program.*, e.g. the HcPkg and GHC modules there. They define program invocations and some handy utilities for calling the programs in various ways. |
23Skidoo
added a commit
that referenced
this pull request
Mar 11, 2013
suppress annoying missing haddock warning for whitelist (rts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://plus.google.com/114991347543804898741/posts/9FbAWEuTFXN
Note: there seems to be a very similar chunk of code in cabal-install Distribution.Client.Haddock. Sounds like there's a refactor wanting to happen there? Not sure what the background is though.